sashapolo commented on code in PR #1348:
URL: https://github.com/apache/ignite-3/pull/1348#discussion_r1026551941
##########
modules/raft/src/test/java/org/apache/ignite/raft/jraft/rpc/impl/cli/ChangePeersAsyncRequestProcessorTest.java:
##########
@@ -22,22 +22,26 @@
import java.util.List;
import org.apache.ignite.raft.jraft.Closure;
-import org.apache.ignite.raft.jraft.JRaftUtils;
import org.apache.ignite.raft.jraft.Node;
import org.apache.ignite.raft.jraft.Status;
+import org.apache.ignite.raft.jraft.conf.Configuration;
import org.apache.ignite.raft.jraft.entity.PeerId;
import org.apache.ignite.raft.jraft.rpc.CliRequests.ChangePeersAsyncRequest;
import org.apache.ignite.raft.jraft.rpc.CliRequests.ChangePeersAsyncResponse;
import org.mockito.ArgumentCaptor;
import org.mockito.Mockito;
public class ChangePeersAsyncRequestProcessorTest extends
AbstractCliRequestProcessorTest<ChangePeersAsyncRequest>{
+ private static final List<String> FOLLOWERS = List.of("follower1",
"follower2");
+ private static final List<String> LEARNERS = List.of("learner1",
"learner2", "learner3");
+
@Override
public ChangePeersAsyncRequest createRequest(String groupId, PeerId
peerId) {
return msgFactory.changePeersAsyncRequest()
.groupId(groupId)
.leaderId(peerId.toString())
- .newPeersList(List.of("localhost:8084", "localhost:8085"))
+ .newPeersList(FOLLOWERS)
Review Comment:
`ChangePeersAsync` is new functionality that is not present in JRaft. So
basically these classes mimic the style of JRaft while being written by us)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
