rpuch commented on code in PR #1348:
URL: https://github.com/apache/ignite-3/pull/1348#discussion_r1026795882
##########
modules/core/src/testFixtures/java/org/apache/ignite/internal/testframework/matchers/CompletableFutureExceptionMatcher.java:
##########
@@ -119,4 +143,11 @@ public static CompletableFutureExceptionMatcher
willThrow(Class<? extends Except
public static CompletableFutureExceptionMatcher willThrow(Class<? extends
Exception> cls, int timeout, TimeUnit timeUnit) {
return willThrow(is(instanceOf(cls)), timeout, timeUnit);
}
+
+ /**
+ * Creates a matcher that matches a future that completes with an
exception that has a given {@code cause} in the exception stacktrace.
+ */
+ public static CompletableFutureExceptionMatcher willThrowWithCause(Class<?
extends Exception> cause) {
Review Comment:
New developers will be quite surprised. Also, when a name is... not exactly
telling truth, it's not good even if everyone is used to it. It's better to
have truthful names :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
