skorotkov commented on code in PR #10624:
URL: https://github.com/apache/ignite/pull/10624#discussion_r1160415517
##########
modules/ducktests/tests/ignitetest/services/utils/control_utility.py:
##########
@@ -220,6 +220,96 @@ def snapshot_create(self, snapshot_name: str, timeout_sec:
int = 60):
raise TimeoutError(f'Failed to wait for the snapshot operation to
complete: '
f'snapshot_name={snapshot_name} in {timeout_sec}
seconds.')
+ def incremental_snapshot_create(self, snapshot_name: str, exp_increment:
int, timeout_sec: int = 60):
+ """
+ Create snapshot.
+ :param snapshot_name: Name of Snapshot.
+ :param exp_increment: Expected increment index.
Review Comment:
Can we do not require the caller of the method to know the expected
increment index? Looks like it may be annoying for the caller.
Can we instead say request the current index before the snapshot command
invokation and return new index as a return value upon the operation completion?
And lets the caller decide if it is expected or not if it wants to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
