skorotkov commented on code in PR #10624:
URL: https://github.com/apache/ignite/pull/10624#discussion_r1160442956
##########
modules/ducktests/src/main/java/org/apache/ignite/internal/ducktest/tests/DataGenerationApplication.java:
##########
Review Comment:
I don't think this new functionality (put in transaction) should be added
into the *DataGenerationApplication*.
For me this is a very unexpected twist:
* transactional == false -> DataStreamer
* transactional == true -> individual puts in transaction
I'd suggest either create another app or may be reuse the
*ContinuousDataLoadApplication* one somehow. It looks much closer to what you
need ("Keeps data load until stopped."). And has some transactions support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
