[GitHub] [ignite-3] sanpwc commented on a diff in pull request #1986: IGNITE-18755 Do not save the empty data nodes list to avoid the distribution zone without a data nodes. Fixed exceptions in test logs of DistributionZoneManagerScaleUpTest, DistributionZoneManagerConfigurationChangesTest, DistributionZoneManagerWatchListenerTest.

[via GitHub]

sanpwc commented on code in PR #1986:
URL: https://github.com/apache/ignite-3/pull/1986#discussion_r1180607008


##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -1595,6 +1598,11 @@ CompletableFuture<Void> 
saveDataNodesToMetaStorageOnScaleDown(int zoneId, long r
                         .thenApply(StatementResult::getAsBoolean)
                         .thenCompose(invokeResult -> inBusyLock(busyLock, () 
-> {
                             if (invokeResult) {
+                                if (newDataNodes.isEmpty()) {
+                                    LOG.debug("Data nodes for a zone was not 
updated because"

Review Comment:
   Should we still update trigger key?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org