sanpwc commented on code in PR #1986:
URL: https://github.com/apache/ignite-3/pull/1986#discussion_r1180613737
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -1595,6 +1598,11 @@ CompletableFuture<Void>
saveDataNodesToMetaStorageOnScaleDown(int zoneId, long r
.thenApply(StatementResult::getAsBoolean)
.thenCompose(invokeResult -> inBusyLock(busyLock, ()
-> {
if (invokeResult) {
+ if (newDataNodes.isEmpty()) {
Review Comment:
How it's supposed to work?
Let's say that we've prepared new dataNodesAndTriggerKeyUpd with new
revision and **same** newDataNodesBytes.
Are we going to actually update dataNodes with same value? Are we going to
consider such same to same change as new rebalance trigger?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
