sergeyuttsel commented on code in PR #1986:
URL: https://github.com/apache/ignite-3/pull/1986#discussion_r1182448324
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -1595,6 +1598,11 @@ CompletableFuture<Void>
saveDataNodesToMetaStorageOnScaleDown(int zoneId, long r
.thenApply(StatementResult::getAsBoolean)
.thenCompose(invokeResult -> inBusyLock(busyLock, ()
-> {
if (invokeResult) {
+ if (newDataNodes.isEmpty()) {
Review Comment:
1. Same to same a data nodes change will not trigger a new rebalance because
RebalanceUtil#updatePendingAssignmentsKeys filters the same assignments.
2. I think we can not save the same data nodes, but it will require more
changes in the code. Actually a meta storage invoke with the same data nodes
can not complete successfully and `saveDataNodesToMetaStorageOnScaleDown` can
be repeated again but with a different set of nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
