sashapolo commented on code in PR #2163:
URL: https://github.com/apache/ignite-3/pull/2163#discussion_r1222956009
##########
modules/network-annotation-processor/src/main/java/org/apache/ignite/internal/network/processor/messages/MarshallableTypesBlackList.java:
##########
@@ -97,11 +126,17 @@ public Boolean visitDeclared(DeclaredType t, Void unused) {
return t.getTypeArguments().stream().anyMatch(this::visit);
}
- return !isSameType(NATIVE_TYPES, t) && !typeUtils.isSubType(t,
NetworkMessage.class);
+ return !isSameType(NATIVE_TYPES, t)
+ && !typeUtils.isSubType(t, NetworkMessage.class)
Review Comment:
I don't want to, because we will have to duplicate them in the test list as
well, plus plain class names are less convenient
##########
modules/network-annotation-processor/src/main/java/org/apache/ignite/internal/network/processor/messages/MarshallableTypesBlackList.java:
##########
@@ -97,11 +126,17 @@ public Boolean visitDeclared(DeclaredType t, Void unused) {
return t.getTypeArguments().stream().anyMatch(this::visit);
}
- return !isSameType(NATIVE_TYPES, t) && !typeUtils.isSubType(t,
NetworkMessage.class);
+ return !isSameType(NATIVE_TYPES, t)
+ && !typeUtils.isSubType(t, NetworkMessage.class)
Review Comment:
I don't want to, because we will have to duplicate them in the test list as
well, text plain class names are less convenient
##########
modules/network-annotation-processor/src/main/java/org/apache/ignite/internal/network/processor/messages/MarshallableTypesBlackList.java:
##########
@@ -97,11 +126,17 @@ public Boolean visitDeclared(DeclaredType t, Void unused) {
return t.getTypeArguments().stream().anyMatch(this::visit);
}
- return !isSameType(NATIVE_TYPES, t) && !typeUtils.isSubType(t,
NetworkMessage.class);
+ return !isSameType(NATIVE_TYPES, t)
+ && !typeUtils.isSubType(t, NetworkMessage.class)
Review Comment:
I don't want to, because we will have to duplicate them in the test list as
well, text class names are less convenient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
