sashapolo commented on code in PR #2163:
URL: https://github.com/apache/ignite-3/pull/2163#discussion_r1222965514
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/IgniteTableImpl.java:
##########
@@ -369,6 +370,16 @@ public <RowT> CompletableFuture<?> upsertAll(
return CompletableFuture.allOf(futures);
}
+ private static List<ByteBuffer> serializeBinaryRows(Collection<BinaryRow>
rows) {
+ var result = new ArrayList<ByteBuffer>(rows.size());
+
+ for (BinaryRow row : rows) {
+ result.add(row.byteBuffer());
Review Comment:
> Should we do it right now, or let's wait until the method is removed?
Let's do it later, I don't want to make stuff more complex prematurely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
