ibessonov commented on code in PR #2163:
URL: https://github.com/apache/ignite-3/pull/2163#discussion_r1222962531
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/IgniteTableImpl.java:
##########
@@ -369,6 +370,16 @@ public <RowT> CompletableFuture<?> upsertAll(
return CompletableFuture.allOf(futures);
}
+ private static List<ByteBuffer> serializeBinaryRows(Collection<BinaryRow>
rows) {
+ var result = new ArrayList<ByteBuffer>(rows.size());
+
+ for (BinaryRow row : rows) {
+ result.add(row.byteBuffer());
Review Comment:
Because what's the point of making a copy of an array if all we want is to
slap a single integer to it. That's extra copying that most likely affects the
performance in negative way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
