korlov42 commented on code in PR #2241:
URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1246227747
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -888,14 +903,6 @@ private CompletableFuture<Void>
awaitFragmentInitialisationAndClose() {
cancelFuts.add(
CompletableFuture.allOf(entry.getValue().toArray(new
CompletableFuture[0]))
- .handle((none2, t) -> {
- // Some fragments may be completed
exceptionally, and that is fine.
- // Here we need to make sure that all
query initialisation requests
- // have been processed before sending a
cancellation request. That's
- // why we just ignore any exception.
-
- return null;
- })
Review Comment:
it's not news that we don't have comprehensive test coverage.
In the very beginning, the comment states "Some fragments may be completed
exceptionally". Therefore, we need to find out whether this invariant is
conserved. There are only 5 usages `remoteFragmentInitCompletion`, so I believe
it's not a rocket science to take a look at every usage. As far as I can see,
`DistributedQueryManager#onNodeLeft` completes init future with exception.
Feel free to add such test to ExecutionServiceImplTest. If it will pass
without mentioned `handle` block, I'm ok to remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
