korlov42 commented on code in PR #2241:
URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1247506243
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -838,33 +838,34 @@ private CompletableFuture<Void> close(boolean cancel) {
: closeLocalFragments();
var finalStepFut = cancelResult.whenComplete((r, e) ->
{
- queryManagerMap.remove(ctx.queryId());
+ if (e != null) {
+ Throwable ex = unwrapCause(e);
- try {
- ctx.cancel().cancel();
- } catch (Exception ignored) {
- // NO-OP
+ LOG.warn("Exception raised during close", ex);
}
+ queryManagerMap.remove(ctx.queryId());
+
+ ctx.cancel().cancel();
Review Comment:
why did you removed try-catch block around cancel?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
