korlov42 commented on code in PR #2241:
URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1250363722
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -838,33 +838,38 @@ private CompletableFuture<Void> close(boolean cancel) {
: closeLocalFragments();
var finalStepFut = cancelResult.whenComplete((r, e) ->
{
+ if (e != null) {
+ Throwable ex = unwrapCause(e);
+
+ LOG.warn(format("Fragment closing processed
with errors, root fragmentId={}", rootFragmentId), ex);
Review Comment:
I've got a few questions regarding this line of code:
1) why don't delegate formatting to logger?
2) how did you come up with rootFragmentId param?
3) have you read logging guidelines?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
