nevdmitry commented on code in PR #2339:
URL: https://github.com/apache/ignite-3/pull/2339#discussion_r1270871008
##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/call/connect/ConnectCall.java:
##########
@@ -47,41 +50,48 @@
* Call for connect to Ignite 3 node. As a result {@link Session} will hold a
valid node-url.
*/
@Singleton
-public class ConnectCall implements Call<UrlCallInput, String> {
- private final Session session;
+public class ConnectCall implements Call<ConnectCallInput, String> {
+ @Inject
+ private Session session;
- private final StateConfigProvider stateConfigProvider;
+ @Inject
+ private StateConfigProvider stateConfigProvider;
- private final ApiClientFactory clientFactory;
+ @Inject
+ private ApiClientFactory clientFactory;
- private final JdbcUrlFactory jdbcUrlFactory;
+ @Inject
+ private JdbcUrlFactory jdbcUrlFactory;
+
+ @Inject
+ private ConfigManagerProvider configManagerProvider;
/**
* Constructor.
*/
- public ConnectCall(Session session, StateConfigProvider
stateConfigProvider, ApiClientFactory clientFactory,
Review Comment:
I see Inject approach in another class and decided that it is new approach
##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/call/connect/ConnectCallInput.java:
##########
@@ -0,0 +1,34 @@
+package org.apache.ignite.internal.cli.call.connect;
+
+import javax.annotation.Nullable;
+import org.apache.ignite.internal.cli.core.call.CallInput;
+
+/** Input for the {@link ConnectCall} call. */
+public class ConnectCallInput implements CallInput {
+
+ private final String url;
+ @Nullable
+ private final String username;
+ @Nullable
+ private final String password;
+
+ public ConnectCallInput(String url, @Nullable String username, @Nullable
String password) {
+ this.url = url;
+ this.username = username;
+ this.password = password;
+ }
+
+ String getUrl() {
Review Comment:
fixed
##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/commands/Options.java:
##########
@@ -258,5 +258,23 @@ public static final class Constants {
public static final String CLUSTER_CONFIG_FILE_OPTION_SHORT = "-cfgf";
public static final String CLUSTER_CONFIG_FILE_OPTION_DESC = "Path to
cluster configuration file";
+
+ public static final String PASSWORD_OPTION = "--password";
+
+ public static final String PASSWORD_OPTION_SHORT = "--pwd";
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
