valepakh commented on code in PR #2339:
URL: https://github.com/apache/ignite-3/pull/2339#discussion_r1291019747
##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/core/rest/ApiClientFactory.java:
##########
@@ -92,7 +92,7 @@ public ApiClient getClient(String path) {
* @return created API client.
*/
public ApiClient getClient(String path, String username, String password) {
- ApiClientSettingsBuilder clientSettingsBuilder = settings(path, false);
+ ApiClientSettingsBuilder clientSettingsBuilder = settingsBuilder(path);
clientSettingsBuilder.basicAuthenticationUsername(username);
clientSettingsBuilder.basicAuthenticationPassword(password);
return getClientFromSettings(clientSettingsBuilder.build());
Review Comment:
I'd just overload the `settingsWithAuth(String username, String password)`.
Also I wonder whether we should move this to the `ApiClientSettingsBuilder`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
