PakhomovAlexander commented on code in PR #2339:
URL: https://github.com/apache/ignite-3/pull/2339#discussion_r1272481803
##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/commands/Options.java:
##########
@@ -261,7 +261,7 @@ public static final class Constants {
public static final String PASSWORD_OPTION = "--password";
- public static final String PASSWORD_OPTION_SHORT = "--pwd";
+ public static final String PASSWORD_OPTION_SHORT = "--p";
Review Comment:
Short options should be defined with single dash `-p`
##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/call/connect/ConnectCallInput.java:
##########
@@ -12,23 +12,54 @@ public class ConnectCallInput implements CallInput {
@Nullable
private final String password;
- public ConnectCallInput(String url, @Nullable String username, @Nullable
String password) {
+ private ConnectCallInput(String url, @Nullable String username, @Nullable
String password) {
this.url = url;
this.username = username;
this.password = password;
}
- String getUrl() {
+ String url() {
return url;
}
@Nullable
- String getUsername() {
+ String username() {
return username;
}
@Nullable
- String getPassword() {
+ String password() {
return password;
}
+
+ public static class ConnectCallInputBuilder {
Review Comment:
When we add a builder to the class we tend to create a static method
`builder()` and close a builder's constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
