zstan commented on code in PR #2368:
URL: https://github.com/apache/ignite-3/pull/2368#discussion_r1285529301
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/util/StatementChecker.java:
##########
@@ -371,14 +387,16 @@ private IgniteSchema createSchema() {
return schema;
}
- private DynamicTest shouldPass(String name, Throwable exception,
Consumer<IgniteRel> check) {
+ private DynamicTest shouldPass(String name, Throwable exception,
Consumer<IgniteRel> check, boolean relCheck) {
return DynamicTest.dynamicTest(name, () -> {
IgniteSchema schema = initSchema(exception);
IgniteRel root;
try {
root = (IgniteRel) sqlPrepare.prepare(schema, sqlStatement,
dynamicParams);
- checkRel(root, schema);
+ if (relCheck) {
Review Comment:
Ok i can change it for extended ver, but it need to be implemented in 2-3
classes, i fill the issue and fill apropriate comment to remove it after fix,
is it ok ?
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/util/StatementChecker.java:
##########
@@ -371,14 +387,16 @@ private IgniteSchema createSchema() {
return schema;
}
- private DynamicTest shouldPass(String name, Throwable exception,
Consumer<IgniteRel> check) {
+ private DynamicTest shouldPass(String name, Throwable exception,
Consumer<IgniteRel> check, boolean relCheck) {
return DynamicTest.dynamicTest(name, () -> {
IgniteSchema schema = initSchema(exception);
IgniteRel root;
try {
root = (IgniteRel) sqlPrepare.prepare(schema, sqlStatement,
dynamicParams);
- checkRel(root, schema);
+ if (relCheck) {
Review Comment:
Ok i can change it with extended ver, but it need to be implemented in 2-3
classes, i fill the issue and fill apropriate comment to remove it after fix,
is it ok ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
