AMashenkov commented on code in PR #2368:
URL: https://github.com/apache/ignite-3/pull/2368#discussion_r1285970882


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/Commons.java:
##########
@@ -169,6 +180,59 @@ public final class Commons {
     private Commons() {
     }
 
+    private static SqlTypeCoercionRule standardCompatibleCoercionRules() {
+        Map<SqlTypeName, ImmutableSet<SqlTypeName>> mappings = new 
EnumMap<>(SqlTypeCoercionRule.instance()

Review Comment:
   Here, we rely on some "standard" mapping that may be changed in newer 
Calcite version, then we remove some rules.
   
   Let's copy static constructor from SqlTypeCoercionRule and comment out or 
drop unwanted rules.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to