sanpwc commented on code in PR #2420:
URL: https://github.com/apache/ignite-3/pull/2420#discussion_r1286669629
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/BaseDistributionZoneManagerTest.java:
##########
@@ -61,7 +62,15 @@
* Base class for {@link DistributionZoneManager} unit tests.
*/
@ExtendWith(ConfigurationExtension.class)
-public class BaseDistributionZoneManagerTest extends BaseIgniteAbstractTest {
+public abstract class BaseDistributionZoneManagerTest extends
BaseIgniteAbstractTest {
+ protected static final String ZONE_NAME = "zone1";
+
+ protected static final int ZONE_ID = 1;
+
+ protected static final long TIMEOUT_MILLIS = 10_000L;
Review Comment:
Please rename both TIMEOUT_MILLIS and TIMER_SECONDS it's not clear what it
means.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
