sanpwc commented on code in PR #2420:
URL: https://github.com/apache/ignite-3/pull/2420#discussion_r1286676690
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerConfigurationChangesTest.java:
##########
@@ -169,18 +172,20 @@ public void setUp() throws Exception {
@AfterEach
public void tearDown() throws Exception {
- distributionZoneManager.stop();
- metaStorageManager.stop();
- clusterCfgMgr.stop();
- vaultMgr.stop();
- generator.close();
+ IgniteUtils.closeAll(
+ distributionZoneManager == null ? null :
distributionZoneManager::stop,
Review Comment:
Why do we need null check here? Do we expect any of closeables to be null in
happy case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
