tkalkirill commented on code in PR #2420:
URL: https://github.com/apache/ignite-3/pull/2420#discussion_r1286716246
##########
modules/distribution-zones/src/testFixtures/java/org/apache/ignite/internal/distributionzones/DistributionZonesTestUtil.java:
##########
@@ -113,11 +113,40 @@ public static CompletableFuture<Integer> createZone(
* @return A future, which will be completed, when create operation
finished.
*/
public static CompletableFuture<Integer> createZone(
- DistributionZoneManager zoneManager, String zoneName,
- int partitions, int replicas) {
+ DistributionZoneManager zoneManager,
+ String zoneName,
+ int partitions,
+ int replicas
+ ) {
return createZone(zoneManager, zoneName, partitions, replicas, null);
}
+ /**
+ * Creates a distribution zone in the configuration.
+ *
+ * @param distributionZoneManager Distributed zone manager.
+ * @param zoneName Zone name.
+ * @param dataNodesAutoAdjustScaleUp Timeout in seconds between node added
topology event itself and data nodes switch,
+ * {@code null} if not set.
+ * @param dataNodesAutoAdjustScaleDown Timeout in seconds between node
left topology event itself and data nodes switch,
+ * {@code null} if not set.
+ * @param filter Nodes filter, {@code null} if not set.
+ */
+ public static void createZone(
Review Comment:
Async method will leave after switch to the catalog.
I propose to leave it as it is, I can change it to synchronous, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
