zstan commented on code in PR #2431:
URL: https://github.com/apache/ignite-3/pull/2431#discussion_r1290909695
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/CastResolutionTest.java:
##########
@@ -50,6 +51,14 @@ public class CastResolutionTest extends AbstractPlannerTest {
private static final Set<String> dtNames =
DATETIME_TYPES.stream().map(SqlTypeName::getName).collect(Collectors.toSet());
+ private static final Set<String> ymInterval =
Set.of(INTERVAL_YEAR.getName(), INTERVAL_MONTH.getName());
+
+ private static final Set<String> dayInterval =
Set.of(INTERVAL_HOUR.getName(), INTERVAL_MINUTE.getName());
Review Comment:
good catch ))) i just don`t want to append intervals like
INTERVAL_DAY_MINUTE, INTERVAL_MINUTE_SECOND for more test simplicity.
SqlTypeName class contains collection wrappers: YEAR_INTERVAL_TYPES,
DAY_INTERVAL_TYPES and i decide that to check one type from this wrappers would
be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
