korlov42 commented on code in PR #2431:
URL: https://github.com/apache/ignite-3/pull/2431#discussion_r1298131426
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/IgniteCustomAssigmentsRules.java:
##########
@@ -97,6 +81,17 @@ private IgniteCustomAssigmentsRules(
rules.add(type, rule);
}
+ rule.addAll(YEAR_INTERVAL_TYPES);
+ rule.addAll(DAY_INTERVAL_TYPES);
Review Comment:
but you have not changed a single line here
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/IgniteCustomAssigmentsRules.java:
##########
@@ -65,30 +65,14 @@ private IgniteCustomAssigmentsRules(
Set<SqlTypeName> rule = EnumSet.noneOf(SqlTypeName.class);
- // IntervalYearMonth is assignable from...
- for (SqlTypeName interval : YEAR_INTERVAL_TYPES) {
- rules.add(interval, YEAR_INTERVAL_TYPES);
- }
- for (SqlTypeName interval : DAY_INTERVAL_TYPES) {
- rules.add(interval, DAY_INTERVAL_TYPES);
- }
-
// MULTISET is assignable from...
rules.add(SqlTypeName.MULTISET, EnumSet.of(SqlTypeName.MULTISET));
rule.clear();
rule.addAll(EXACT_TYPES);
- rule.addAll(APPROX_TYPES);
+ rule.addAll(FRACTIONAL_TYPES);
Review Comment:
why have you changed APPROX_TYPES to FRACTIONAL_TYPES?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
