zstan commented on code in PR #2431:
URL: https://github.com/apache/ignite-3/pull/2431#discussion_r1294492007
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/IgniteCustomAssigmentsRules.java:
##########
@@ -81,14 +73,6 @@ private IgniteCustomAssigmentsRules(
rule.addAll(APPROX_TYPES);
rule.addAll(CHAR_TYPES);
- // TINYINT is assignable from...
- // SMALLINT is assignable from...
- // INTEGER is assignable from...
- // BIGINT is assignable from...
- for (SqlTypeName type : EXACT_TYPES) {
- rules.add(type, rule);
- }
-
// FLOAT (up to 64 bit floating point) is assignable from...
// REAL (32 bit floating point) is assignable from...
// DOUBLE is assignable from...
Review Comment:
i think it`s all ok there
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/CastResolutionTest.java:
##########
@@ -50,6 +51,14 @@ public class CastResolutionTest extends AbstractPlannerTest {
private static final Set<String> dtNames =
DATETIME_TYPES.stream().map(SqlTypeName::getName).collect(Collectors.toSet());
+ private static final Set<String> ymInterval =
Set.of(INTERVAL_YEAR.getName(), INTERVAL_MONTH.getName());
+
+ private static final Set<String> dayInterval =
Set.of(INTERVAL_HOUR.getName(), INTERVAL_MINUTE.getName());
Review Comment:
additional tests appended
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
