AMashenkov commented on code in PR #2441:
URL: https://github.com/apache/ignite-3/pull/2441#discussion_r1294884216
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -172,7 +173,7 @@ public static <RowT> ExecutionServiceImpl<RowT> create(
dependencyResolver,
(ctx, deps) -> new LogicalRelImplementor<>(
ctx,
- new HashFunctionFactoryImpl<>(sqlSchemaManager,
handler),
+ new
HashFunctionFactoryImpl<>(ctx.getRootSchema().unwrap(IgniteSchema.class),
handler),
Review Comment:
I didn't catch what is your suggestion.
A query may use multiple tables, e.g. in joins. At a moment Factory is
created, there is no tableID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
