AMashenkov commented on code in PR #2441:
URL: https://github.com/apache/ignite-3/pull/2441#discussion_r1295607824
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutableTableRegistryImpl.java:
##########
@@ -138,4 +169,35 @@ public CompletableFuture<ColocationGroup>
fetchColocationGroup() {
});
}
}
+
+ private static CacheKey cacheKey(int tableId, int version) {
+ return new CacheKey(tableId, version);
+ }
+
+ private static class CacheKey {
Review Comment:
I don't think class should be named with it's fields names.
It is a cache key, just a union of random values, which don't imply any
meaningful structure/abstaction together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
