AMashenkov commented on code in PR #2441:
URL: https://github.com/apache/ignite-3/pull/2441#discussion_r1294894866
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -172,7 +173,7 @@ public static <RowT> ExecutionServiceImpl<RowT> create(
dependencyResolver,
(ctx, deps) -> new LogicalRelImplementor<>(
ctx,
- new HashFunctionFactoryImpl<>(sqlSchemaManager,
handler),
+ new
HashFunctionFactoryImpl<>(ctx.getRootSchema().unwrap(IgniteSchema.class),
handler),
Review Comment:
`DistributionFunction.destination()` must not accepts an external
HashFunctionFactory, it just should calculate destinations by its own. Thus, no
hash-function factory should be passed to RelImplementor from the outside, but
this is out of scope now.
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -172,7 +173,7 @@ public static <RowT> ExecutionServiceImpl<RowT> create(
dependencyResolver,
(ctx, deps) -> new LogicalRelImplementor<>(
ctx,
- new HashFunctionFactoryImpl<>(sqlSchemaManager,
handler),
+ new
HashFunctionFactoryImpl<>(ctx.getRootSchema().unwrap(IgniteSchema.class),
handler),
Review Comment:
`DistributionFunction.destination()` must not accepts an external
HashFunctionFactory, it just should calculate destinations by its own.
Thus, no hash-function factory should be passed to RelImplementor from the
outside, but maybe via dependencies. Anyway, this is out of scope now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
