tkalkirill commented on code in PR #2415:
URL: https://github.com/apache/ignite-3/pull/2415#discussion_r1303840455
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/configuration/storage/ItRebalanceDistributedTest.java:
##########
@@ -1076,29 +1069,41 @@ private static void createZone(Node node, String
zoneName, int partitions, int r
}
private static void createZone(Node node, String zoneName, int partitions,
int replicas, boolean testDataStorage) {
- DistributionZonesTestUtil.createZone(
- node.distributionZoneManager,
+ DistributionZonesTestUtil.createZoneWithDataStorage(
+ node.catalogManager,
zoneName,
partitions,
replicas,
- testDataStorage ? (dataStorageChange ->
dataStorageChange.convert(TestDataStorageChange.class)) : null
+ testDataStorage ? TestStorageEngine.ENGINE_NAME : null
);
}
private static void alterZone(Node node, String zoneName, int replicas) {
- alterZoneReplicas(node.distributionZoneManager, zoneName, replicas);
+ DistributionZonesTestUtil.alterZone(node.catalogManager, zoneName,
replicas);
}
private static void createTable(Node node, String zoneName, String
tableName) {
- TableDefinition schTbl1 =
SchemaBuilders.tableBuilder(DEFAULT_SCHEMA_NAME, tableName).columns(
+ TableTestUtils.createTable(
+ node.catalogManager,
+ DEFAULT_SCHEMA_NAME,
+ zoneName,
+ tableName,
+ List.of(
+
ColumnParams.builder().name("key").type(org.apache.ignite.sql.ColumnType.INT64).build(),
+
ColumnParams.builder().name("val").type(org.apache.ignite.sql.ColumnType.INT32).nullable(true).build()
+ ),
+ List.of("key")
+ );
+
+ TableDefinition tableDefinition =
SchemaBuilders.tableBuilder(DEFAULT_SCHEMA_NAME, tableName).columns(
Review Comment:
For convenience, when I started doing the task, I discovered that many tests
created the zone directly through the manager instead of using auxiliary
methods, which introduced quite a lot of unpleasant refactorings.
To reduce refactoring in the future, I created this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
