sanpwc commented on code in PR #2415:
URL: https://github.com/apache/ignite-3/pull/2415#discussion_r1305577575
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -282,25 +253,10 @@ public DistributionZoneManager(
);
}
- /** {@inheritDoc} */
@Override
public void start() {
- if (!busyLock.enterBusy()) {
- throw new IgniteException(NODE_STOPPING_ERR, new
NodeStoppingException());
- }
-
- try {
- ZonesConfigurationListener zonesConfigurationListener = new
ZonesConfigurationListener();
-
-
zonesConfiguration.distributionZones().listenElements(zonesConfigurationListener);
-
zonesConfiguration.distributionZones().any().dataNodesAutoAdjustScaleUp().listen(onUpdateScaleUp());
-
zonesConfiguration.distributionZones().any().dataNodesAutoAdjustScaleDown().listen(onUpdateScaleDown());
-
zonesConfiguration.distributionZones().any().filter().listen(onUpdateFilter());
-
-
zonesConfiguration.defaultDistributionZone().listen(zonesConfigurationListener);
-
zonesConfiguration.defaultDistributionZone().dataNodesAutoAdjustScaleUp().listen(onUpdateScaleUp());
-
zonesConfiguration.defaultDistributionZone().dataNodesAutoAdjustScaleDown().listen(onUpdateScaleDown());
-
zonesConfiguration.defaultDistributionZone().filter().listen(onUpdateFilter());
+ inBusyLock(busyLock, () -> {
+ registerCatalogEventListenersOnStartManagerBusy();
rebalanceEngine.start();
Review Comment:
I would say that we should start rebalanceEngine at the very end of
DZM.start, or more formally after DZM local state recovery.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
