tkalkirill commented on code in PR #2415:
URL: https://github.com/apache/ignite-3/pull/2415#discussion_r1305210927
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/configuration/storage/ItRebalanceDistributedTest.java:
##########
@@ -1076,29 +1069,41 @@ private static void createZone(Node node, String
zoneName, int partitions, int r
}
private static void createZone(Node node, String zoneName, int partitions,
int replicas, boolean testDataStorage) {
- DistributionZonesTestUtil.createZone(
- node.distributionZoneManager,
+ DistributionZonesTestUtil.createZoneWithDataStorage(
+ node.catalogManager,
zoneName,
partitions,
replicas,
- testDataStorage ? (dataStorageChange ->
dataStorageChange.convert(TestDataStorageChange.class)) : null
+ testDataStorage ? TestStorageEngine.ENGINE_NAME : null
);
}
private static void alterZone(Node node, String zoneName, int replicas) {
- alterZoneReplicas(node.distributionZoneManager, zoneName, replicas);
+ DistributionZonesTestUtil.alterZone(node.catalogManager, zoneName,
replicas);
}
private static void createTable(Node node, String zoneName, String
tableName) {
- TableDefinition schTbl1 =
SchemaBuilders.tableBuilder(DEFAULT_SCHEMA_NAME, tableName).columns(
+ TableTestUtils.createTable(
+ node.catalogManager,
+ DEFAULT_SCHEMA_NAME,
+ zoneName,
+ tableName,
+ List.of(
+
ColumnParams.builder().name("key").type(org.apache.ignite.sql.ColumnType.INT64).build(),
+
ColumnParams.builder().name("val").type(org.apache.ignite.sql.ColumnType.INT32).nullable(true).build()
+ ),
+ List.of("key")
+ );
+
+ TableDefinition tableDefinition =
SchemaBuilders.tableBuilder(DEFAULT_SCHEMA_NAME, tableName).columns(
Review Comment:
It took me quite a bit of effort to fix the tests and change them to the new
API.
I was helped in this by using methods instead of explicitly calling the API.
Since this method has proven to be more effective so far (it will also
reduce the pain of trying to merge `catalog-feature` into `main`), I will stick
with it and try to stick with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
