[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2500: IGNITE-19499 TableManager should listen CatalogService events instead of configuration

[via GitHub]

tkalkirill commented on code in PR #2500:
URL: https://github.com/apache/ignite-3/pull/2500#discussion_r1319424029


##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java:
##########
@@ -350,7 +350,7 @@ public CompletableFuture<Void> dropTable(DropTableParams 
params) {
 
             Arrays.stream(schema.indexes())
                     .filter(index -> index.tableId() == table.id())
-                    .forEach(index -> updateEntries.add(new 
DropIndexEntry(index.id(), index.tableId(), table.name())));
+                    .forEach(index -> updateEntries.add(new 
DropIndexEntry(index.id(), index.tableId())));

Review Comment:
   Yes, the busyLock is not used anywhere in this class, created 
[IGNITE-20381](https://issues.apache.org/jira/browse/IGNITE-20381)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org