[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2500: IGNITE-19499 TableManager should listen CatalogService events instead of configuration

[via GitHub]

tkalkirill commented on code in PR #2500:
URL: https://github.com/apache/ignite-3/pull/2500#discussion_r1319452641


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItTablesApiTest.java:
##########
@@ -486,14 +431,17 @@ private void addColumnInternal(Ignite node, String 
tableName, ColumnDefinition c
      * @param node Ignite node.
      * @param tableName Table name.
      */
-    protected void addColumnIfNotExists(Ignite node, String tableName) {
-        ColumnDefinition col = SchemaBuilders.column("valStrNew", 
ColumnType.string()).asNullable(true)
-                .withDefaultValue("default").build();
-
+    private static void addColumnIfNotExists(Ignite node, String tableName) {
         try {
-            addColumnInternal(node, tableName, col);
-        } catch (ColumnAlreadyExistsException ex) {
-            log.info("Column already exists [naem={}]", col.name());
+            addColumn(node, tableName);
+        } catch (ColumnAlreadyExistsException e) {
+            log.info("Column already exists", e);

Review Comment:
   I noticed that this check is useless, since in SQL we do not have support 
for the added column `IF NOT EXISTS`, I deleted it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org