sashapolo commented on code in PR #2596:
URL: https://github.com/apache/ignite-3/pull/2596#discussion_r1329666633
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/LeaseTracker.java:
##########
@@ -89,33 +86,25 @@ public class LeaseTracker extends
AbstractEventProducer<PrimaryReplicaEvent, Pri
/** Listener to update a leases cache. */
private final UpdateListener updateListener = new UpdateListener();
- /** Versioned value used only at manager startup to correctly fire table
creation events. */
- private final IncrementalVersionedValue<Void> startVv;
-
/**
* Constructor.
*
- * @param registry Registry for versioned values.
* @param msManager Meta storage manager.
*/
- public LeaseTracker(Consumer<LongFunction<CompletableFuture<?>>> registry,
MetaStorageManager msManager) {
+ public LeaseTracker(MetaStorageManager msManager) {
this.msManager = msManager;
-
- startVv = new IncrementalVersionedValue<>(registry);
}
- /** Recoveries state from Vault and subscribers on further updates. */
- public void startTrack() {
- inBusyLock(busyLock, () -> {
+ /**
+ * Recoveries state from Vault and subscribers on further updates.
Review Comment:
```suggestion
* Recovers state from Vault and subscribes to future updates.
```
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/PlacementDriverManager.java:
##########
@@ -242,4 +250,22 @@ boolean isActiveActor() {
public PlacementDriver placementDriver() {
return leaseTracker;
}
+
+ private void recoveryInternalComponents() {
Review Comment:
Should be called `recoverInternalComponents`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
