tkalkirill commented on code in PR #2596:
URL: https://github.com/apache/ignite-3/pull/2596#discussion_r1332792171
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/LeaseTracker.java:
##########
@@ -196,12 +185,13 @@ public CompletableFuture<Void> onUpdate(WatchEvent event)
{
LeaseTracker.this.leases = new
Leases(unmodifiableMap(leasesMap), leasesBytes);
}
- return completedFuture(null);
+ return
allOf(fireEventFutures.toArray(CompletableFuture[]::new));
Review Comment:
I don’t quite understand your question, if you’re talking about
**ReplicaListener#onBecomePrimary**, then we’ll get rid of this method soon.
Well, or I completely dont understand why you want to block the metastor for
**ReplicaListener#onBecomePrimary**.
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/LeaseTracker.java:
##########
@@ -196,12 +185,13 @@ public CompletableFuture<Void> onUpdate(WatchEvent event)
{
LeaseTracker.this.leases = new
Leases(unmodifiableMap(leasesMap), leasesBytes);
}
- return completedFuture(null);
+ return
allOf(fireEventFutures.toArray(CompletableFuture[]::new));
Review Comment:
I don’t quite understand your question, if you’re talking about
**ReplicaListener#onBecomePrimary**, then we’ll get rid of this method soon.
Well, or I completely dont understand why you want to block the metastor for
**ReplicaListener#onBecomePrimary**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
