tkalkirill commented on code in PR #2596:
URL: https://github.com/apache/ignite-3/pull/2596#discussion_r1332968321


##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/PlacementDriverManager.java:
##########
@@ -238,4 +250,24 @@ boolean isActiveActor() {
     public PlacementDriver placementDriver() {
         return leaseTracker;
     }
+
+    private void recoverInternalComponentsBusy() {
+        CompletableFuture<Long> recoveryFinishedFuture = 
metastore.recoveryFinishedFuture();
+
+        assert recoveryFinishedFuture.isDone();
+
+        long recoveryRevision = recoveryFinishedFuture.join();
+
+        CompletableFuture<Void> startLeaserTrackerFuture = 
leaseTracker.startTrackAsync(recoveryRevision);
+
+        // Forces to wait until recovery is complete before the metastore 
watches is deployed to avoid races with other components.

Review Comment:
   We discussed it personally, figured out why this was needed, and Alexander 
also asked to do the same for `AssignmentsTracker#startTrack`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to