sanpwc commented on code in PR #2596:
URL: https://github.com/apache/ignite-3/pull/2596#discussion_r1333236699
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/LeaseTracker.java:
##########
@@ -181,6 +170,10 @@ public CompletableFuture<Void> onUpdate(WatchEvent event) {
primaryReplicaWaiters
.computeIfAbsent(grpId, groupId -> new
PendingIndependentComparableValuesTracker<>(MIN_VALUE))
.update(lease.getExpirationTime(), lease);
+
+ if (!previousLeasesGroupIds.contains(grpId)) {
Review Comment:
That seems incorrect. That fact that there was lease for grpId doesn't mean
that it was prolongated. E.g. it might be assigned to another leaseholder. By
the way, this means that test is either missing or incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
