lowka commented on code in PR #2690:
URL: https://github.com/apache/ignite-3/pull/2690#discussion_r1365242159
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java:
##########
@@ -434,4 +503,31 @@ public boolean rolledUpColumnValidInsideAgg(String column,
SqlCall call,
return true;
}
}
+
+ private static long divide(long p, long q, RoundingMode mode) {
Review Comment:
We need HALF_UP for ROUND function and HALF_DOWN for TRUNCATE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
