korlov42 commented on code in PR #2690:
URL: https://github.com/apache/ignite-3/pull/2690#discussion_r1365058978


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/RexImpTable.java:
##########
@@ -4359,6 +4364,26 @@ private static class DefaultImplementor extends 
AbstractRexCallImplementor {
     }
   }
 
+  private static class IgniteMethodNameImplementor extends 
AbstractRexCallImplementor {

Review Comment:
   > Because defineMethod expects that all methods to be defined on calcite's 
SqlFunctions
   
   that's not true, you could supply reference to particular 
`java.lang.reflect.Method`. In that case you can use static method from any 
class
   
   > And it is not possible to define a method with multiple overloads in 
IgniteSqlFunctions
   
   why do you can define multiple overloads in `SqlFunctions`, but not in 
`IgniteSqlFunctions`? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to