korlov42 commented on code in PR #2690:
URL: https://github.com/apache/ignite-3/pull/2690#discussion_r1365015533
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctionsTest.java:
##########
@@ -242,4 +245,57 @@ public void testConvertDecimal(String input, int
precision, int scale, String re
assertThrowsSqlException(Sql.RUNTIME_ERR, "Numeric field
overflow", convert::get);
}
}
+
+ /** Tests for ROUND(x) function. */
+ @Test
+ public void testRound() {
Review Comment:
> int, long, double and BigDecimal. shorts and byte are promoted to ints by
calcite.
why do we need `int` version then? 🤔
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctionsTest.java:
##########
@@ -242,4 +245,57 @@ public void testConvertDecimal(String input, int
precision, int scale, String re
assertThrowsSqlException(Sql.RUNTIME_ERR, "Numeric field
overflow", convert::get);
}
}
+
+ /** Tests for ROUND(x) function. */
+ @Test
+ public void testRound() {
Review Comment:
> int, long, double and BigDecimal. shorts and byte are promoted to ints by
calcite.
why do we need `int` version then? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
