lowka commented on code in PR #2915:
URL: https://github.com/apache/ignite-3/pull/2915#discussion_r1417681742
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/sql/SqlAlterColumnDdlParserTest.java:
##########
@@ -53,8 +46,15 @@ public class SqlAlterColumnDdlParserTest extends
AbstractDdlParserTest {
*/
@Test
public void testNotNull() {
- assertThat(parseAlterColumn("SET NOT NULL").notNull(), is(true));
- assertThat(parseAlterColumn("DROP NOT NULL").notNull(), is(false));
+ IgniteSqlAlterColumn alterColumn = parseAlterColumn("ALTER TABLE t
ALTER COLUMN a SET NOT NULL");
+ assertThat(alterColumn.notNull(), is(true));
+ expectUnparsed(alterColumn, "ALTER TABLE \"T\" ALTER COLUMN \"A\" SET
NOT NULL");
+
+ assertThat(alterColumn.notNull(), is(true));
Review Comment:
Thanks. Fixed.
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/IgniteSqlCreateZone.java:
##########
@@ -35,14 +35,31 @@
* Parse tree for {@code CREATE ZONE} statement with Ignite specific features.
*/
public class IgniteSqlCreateZone extends SqlCreate {
+
+ /** CREATE ZONE operator. */
+ protected static class Operator extends IgniteDdlOperator {
+
+ /** Constructor. */
+ protected Operator(boolean existFlag) {
+ super("ALTER ZONE", SqlKind.OTHER_DDL, existFlag);
Review Comment:
Thanks. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
