xtern commented on code in PR #2915:
URL: https://github.com/apache/ignite-3/pull/2915#discussion_r1418681529
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/sql/SqlTransactionControlParserTest.java:
##########
@@ -62,14 +61,7 @@ public void testCommit() {
expectUnparsed(node, sql);
}
- private static SqlNode parseStatement(String sqlStmt) {
- return IgniteSqlParser.parse(sqlStmt,
StatementParseResult.MODE).statement();
- }
-
- private static void expectUnparsed(SqlNode node, String expected) {
- SqlPrettyWriter writer = new SqlPrettyWriter();
- node.unparse(writer, 0, 0);
-
- assertEquals(expected, writer.toString(), "Unparse does not match");
+ private SqlNode parseStatement(String sqlStmt) {
Review Comment:
Maybe it's worth removing this method completely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]