xtern commented on code in PR #2915:
URL: https://github.com/apache/ignite-3/pull/2915#discussion_r1418675408
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/sql/SqlAlterColumnDdlParserTest.java:
##########
@@ -96,22 +101,42 @@ public void testDefault() {
*/
@Test
public void testSetDataType() {
- validateDataType("SET DATA TYPE INTEGER", "INTEGER", null, null);
- validateDataType("SET DATA TYPE INTEGER NOT NULL", "INTEGER", true,
null);
- validateDataType("SET DATA TYPE INTEGER NULL", "INTEGER", false, null);
- validateDataType("SET DATA TYPE INTEGER DEFAULT -1", "INTEGER", null,
-1L);
- validateDataType("SET DATA TYPE INTEGER DEFAULT NULL", "INTEGER",
null, null);
- validateDataType("SET DATA TYPE INTEGER NOT NULL DEFAULT -1",
"INTEGER", true, -1);
- validateDataType("SET DATA TYPE INTEGER NULL DEFAULT NULL", "INTEGER",
false, null);
+ IgniteSqlAlterColumn alterColumn = parseAlterColumn("ALTER TABLE t
ALTER COLUMN c SET DATA TYPE INTEGER");
+ expectDataType(alterColumn, "INTEGER", null, null);
+ expectUnparsed(alterColumn, "ALTER TABLE \"T\" ALTER COLUMN \"C\" SET
DATA TYPE INTEGER");
+
+ alterColumn = parseAlterColumn("ALTER TABLE t ALTER COLUMN c SET DATA
TYPE INTEGER NOT NULL");
+ expectDataType(alterColumn, "INTEGER", true, null);
+ expectUnparsed(alterColumn, "ALTER TABLE \"T\" ALTER COLUMN \"C\" SET
DATA TYPE INTEGER NOT NULL");
+
+ alterColumn = parseAlterColumn("ALTER TABLE t ALTER COLUMN c SET DATA
TYPE INTEGER NULL");
+ expectDataType(alterColumn, "INTEGER", false, null);
+ expectUnparsed(alterColumn, "ALTER TABLE \"T\" ALTER COLUMN \"C\" SET
DATA TYPE INTEGER NULL");
+
+ alterColumn = parseAlterColumn("ALTER TABLE t ALTER COLUMN c SET DATA
TYPE INTEGER DEFAULT -1");
+ expectDataType(alterColumn, "INTEGER", null, -1);
+ expectUnparsed(alterColumn, "ALTER TABLE \"T\" ALTER COLUMN \"C\" SET
DATA TYPE INTEGER DEFAULT -1");
+
+ alterColumn = parseAlterColumn("ALTER TABLE t ALTER COLUMN c SET DATA
TYPE INTEGER NOT NULL DEFAULT -1");
Review Comment:
this case is duplicates below, I think the case `SET DATA TYPE INTEGER
DEFAULT NULL` is missing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
