korlov42 commented on code in PR #2965:
URL: https://github.com/apache/ignite-3/pull/2965#discussion_r1433863289
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java:
##########
@@ -656,9 +649,10 @@ private CompletableFuture<SchemaPlus>
waitForActualSchema(String schemaName, Hyb
}
}
- private AsyncSqlCursor<InternalSqlRow> executePlan(
+ private CompletableFuture<AsyncSqlCursor<InternalSqlRow>> executePlan(
QueryTransactionWrapper txWrapper,
BaseQueryContext ctx,
+ PrefetchCallback callback,
Review Comment:
actually, we can't. I passed it explicitly in order to preserve type
`PrefetchCallback` since I need a future, not the callback to notify. Another
options are to do a cast from `QueryPrefetchCallback` to `PrefetchCallback`,
and to extend QueryPrefetchCallback exposing a future.
I prefer to pass callback explicitly, this approach seams to be lesser evil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
