korlov42 commented on code in PR #2965:
URL: https://github.com/apache/ignite-3/pull/2965#discussion_r1433873158
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java:
##########
@@ -603,12 +607,11 @@ private CompletableFuture<AsyncSqlCursor<InternalSqlRow>>
executeParsedStatement
QueryTransactionWrapper txWrapper,
QueryCancel queryCancel,
Object[] params,
- boolean waitForPrefetch,
@Nullable CompletableFuture<AsyncSqlCursor<InternalSqlRow>>
nextStatement
) {
return waitForActualSchema(schemaName,
txWrapper.unwrap().startTimestamp())
.thenCompose(schema -> {
- PrefetchCallback callback = waitForPrefetch ? new
PrefetchCallback() : null;
+ PrefetchCallback callback = new PrefetchCallback();
Review Comment:
to be honest, I don't like this callback either. But at the moment I have no
idea how to do it better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
