xtern commented on code in PR #2965:
URL: https://github.com/apache/ignite-3/pull/2965#discussion_r1433894517
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java:
##########
@@ -656,9 +649,10 @@ private CompletableFuture<SchemaPlus>
waitForActualSchema(String schemaName, Hyb
}
}
- private AsyncSqlCursor<InternalSqlRow> executePlan(
+ private CompletableFuture<AsyncSqlCursor<InternalSqlRow>> executePlan(
QueryTransactionWrapper txWrapper,
BaseQueryContext ctx,
+ PrefetchCallback callback,
Review Comment:
> since I need a future
Oh yeah, I missed that `QueryPrefetchCallback` is an implementation of
`PrefetchCallback`.
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java:
##########
@@ -656,9 +649,10 @@ private CompletableFuture<SchemaPlus>
waitForActualSchema(String schemaName, Hyb
}
}
- private AsyncSqlCursor<InternalSqlRow> executePlan(
+ private CompletableFuture<AsyncSqlCursor<InternalSqlRow>> executePlan(
QueryTransactionWrapper txWrapper,
BaseQueryContext ctx,
+ PrefetchCallback callback,
Review Comment:
> since I need a future
Oh yeah, I missed that `QueryPrefetchCallback` is an implementation of
`PrefetchCallback`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
