ygerzhedovich commented on code in PR #2982:
URL: https://github.com/apache/ignite-3/pull/2982#discussion_r1438305778
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/MappingServiceImpl.java:
##########
@@ -96,12 +108,54 @@ public CompletableFuture<List<MappedFragment>>
map(MultiStepPlan multiStepPlan)
return initialTopologyFuture.thenComposeAsync(ignore ->
map0(multiStepPlan), taskExecutor);
}
+ /** Called when the primary replica has expired. */
+ public CompletableFuture<Boolean>
onPrimaryReplicaExpired(PrimaryReplicaEventParameters parameters) {
+ assert parameters != null;
+ assert parameters.groupId() instanceof TablePartitionId;
+
+ int tabId = ((TablePartitionId) parameters.groupId()).tableId();
+
+ return CompletableFuture.supplyAsync(() -> {
+ mappingsCache.values().removeIf(value ->
value.tableIds.contains(tabId));
+
+ return false;
+ }, ForkJoinPool.commonPool());
+ }
+
private CompletableFuture<List<MappedFragment>> map0(MultiStepPlan
multiStepPlan) {
List<String> nodes = topologyHolder.nodes();
MappingContext context = new MappingContext(localNodeName, nodes);
FragmentsTemplate template = getOrCreateTemplate(multiStepPlan,
context);
+ MappingsCacheValue cacheValue =
mappingsCache.compute(multiStepPlan.id(), (key, val) -> {
+ if (val == null) {
+ IntSet tableIds = new IntOpenHashSet();
+ boolean topAware = false;
+
+ for (Fragment fragment : template.fragments) {
+ topAware = topAware || !fragment.systemViews().isEmpty();
+ for (IgniteDataSource source : fragment.tables()) {
+ tableIds.add(source.id());
+ }
+ }
+
+ long topVer = topAware ? topologyHolder.ver : Long.MAX_VALUE;
+
+ return new MappingsCacheValue(topVer, tableIds,
mapFragments(context, template));
+ }
+
+ if (val.topVer < topologyHolder.ver) {
Review Comment:
`<=` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
