ygerzhedovich commented on code in PR #2982:
URL: https://github.com/apache/ignite-3/pull/2982#discussion_r1438307211


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/MappingServiceImpl.java:
##########
@@ -169,6 +223,8 @@ private CompletableFuture<List<MappedFragment>> 
map0(MultiStepPlan multiStepPlan
                             }
 
                             lastAttemptSucceed = true;
+
+                            break;

Review Comment:
   good catch. I think potentially more obvious will be add the condition to 
for loop instead of `break` statement here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to