korlov42 commented on code in PR #3264:
URL: https://github.com/apache/ignite-3/pull/3264#discussion_r1502107964
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionContext.java:
##########
@@ -310,6 +311,10 @@ public void execute(RunnableX task, Consumer<Throwable>
onError) {
} catch (Throwable e) {
onError.accept(e);
+ if (e instanceof IgniteException) {
Review Comment:
perhaps, we should not re-throw exceptions here at all. WDYT?
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExchangeServiceImpl.java:
##########
@@ -114,9 +114,7 @@ public CompletableFuture<Void> sendError(String nodeName,
UUID queryId, long fra
if (!(traceableErr instanceof TraceableException)) {
traceableErr = error = new IgniteInternalException(INTERNAL_ERR,
error);
- }
- if (!(traceableErr instanceof QueryCancelledException)) {
Review Comment:
why did you merge these branches?
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/QueryTaskExecutorImpl.java:
##########
@@ -81,15 +81,30 @@ public void execute(UUID qryId, long fragmentId, Runnable
qryTask) {
() -> {
try {
qryTask.run();
+ } catch (IgniteException | IgniteInternalException iex) {
+ //it's normal situation when we have our own exception
here. Just ignore.
+ LOG.debug("Uncaught exception", iex);
Review Comment:
instead of deciding for caller which exceptions are severe and which are
not, why don't force caller to do exception handling in submitted task? In my
opinion, every exception is severe on this level, thus I would just submit
everything to `failureProcessor`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
