zstan commented on code in PR #3264:
URL: https://github.com/apache/ignite-3/pull/3264#discussion_r1523076103
##########
modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/FailureProcessor.java:
##########
@@ -49,6 +51,8 @@ public class FailureProcessor implements IgniteComponent {
/** Node name. */
private final String nodeName;
+ private volatile @Nullable FailureHandler interceptor;
Review Comment:
no need volatile, i suppose ?
##########
modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/FailureProcessor.java:
##########
@@ -145,4 +153,9 @@ private static boolean failureTypeIgnored(FailureContext
failureCtx, FailureHand
return handler instanceof AbstractFailureHandler
&& ((AbstractFailureHandler)
handler).ignoredFailureTypes().contains(failureCtx.type());
}
+
+ @TestOnly
+ public void setInterceptor(@Nullable FailureHandler interceptor) {
Review Comment:
```suggestion
public synchronized void setInterceptor(@Nullable FailureHandler
interceptor) {
```
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java:
##########
@@ -799,4 +822,19 @@ private static Stream<Arguments> decimalLimits() {
arguments(SqlTypeName.TINYINT.getName(), Byte.MAX_VALUE,
Byte.MIN_VALUE)
);
}
+
+ private class InterceptFailHandler implements FailureHandler {
Review Comment:
```suggestion
private class InterceptFailHandler implements FailureHandler {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
