ygerzhedovich commented on code in PR #3264:
URL: https://github.com/apache/ignite-3/pull/3264#discussion_r1521301133
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExchangeServiceImpl.java:
##########
@@ -170,6 +168,10 @@ private void onMessage(String nodeName, QueryBatchMessage
msg) {
} catch (Throwable e) {
inbox.onError(e);
+ if (e instanceof IgniteException) {
Review Comment:
IgniteException is our own exception which we expect here and which will be
processed by inbox. For any other exception we consider as unexpected error
which should be processed by fail handler.
As example situation when it works - we trying insert value wider then
allowed values. In this case we receive SqlException with `INTEGER out of
range` (for example) and the error is expected.
To write test right now is hard unfortunately due to we can't configure fail
handler yet. I will try invent how it can be tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
